[PATCH] [UBSan] Allow UBSan location to store frames returned by symbolizer.

Filipe Cabecinhas filcab+llvm.phabricator at gmail.com
Tue Feb 10 18:35:08 PST 2015


LGTM with the call to InternalFree.


================
Comment at: lib/ubsan/ubsan_diag.h:29
@@ -27,1 +28,3 @@
+      Stack->ClearAll();
+  }
 
----------------
Aren't we still leaking the SymbolizedStack object, here? (as well as in the destructor and reset() (which call clear()))
I guess we're missing a call to InternalFree()

http://reviews.llvm.org/D7548

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list