[PATCH] prevent folding a scalar FP load into a packed logical FP instruction (PR22371)

Quentin Colombet qcolombet at apple.com
Tue Feb 10 15:24:46 PST 2015


Hi Sanjay,


================
Comment at: test/CodeGen/X86/logical-load-fold.ll:9
@@ +8,3 @@
+; executed as a scalar ('movs*') with a zero extension to
+; 128-bits and then used in the packed logical ('andp*') op. 
+; PR22371 - http://llvm.org/bugs/show_bug.cgi?id=22371
----------------
Do we really care about that?

Unless we hit some read protection error, I do not see why reading undefined memory is a problem as long as we use only the part that is defined.
It seems that is the case in those cases, isn’t it?

http://reviews.llvm.org/D7474

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list