[PATCH] [UBSan] Add report deduplication for -fsanitize=function.

Alexey Samsonov vonosmas at gmail.com
Tue Feb 10 12:03:13 PST 2015


================
Comment at: test/ubsan/TestCases/TypeCheck/Function/function.cpp:26
@@ +25,3 @@
+  // Check that no more errors will be printed.
+  // CHECK-NOT: runtime error: call to function
+  make_invalid_call();
----------------
pcc wrote:
> Do we want a `NOSYM-NOT` here as well?
Done

================
Comment at: test/ubsan/TestCases/TypeCheck/Function/function.cpp:28
@@ -23,2 +27,3 @@
+  make_invalid_call();
   reinterpret_cast<void (*)(int)>(reinterpret_cast<uintptr_t>(g))(42);
 }
----------------
pcc wrote:
> Can we move this call to the top of `main` and re-instate its `CHECK-NOT`? That way, we know that if we don't warn about it, it was not because of deduplication.
Done

http://reviews.llvm.org/D7524

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list