[PATCH] Update all CMake files in LLVM to use ADDITIONAL_HEADER_DIRS

Zachary Turner zturner at google.com
Mon Feb 9 21:47:57 PST 2015


Hi beanz,

As of r228670, add_llvm_library() supports the ADDITIONAL_HEADER_DIRS argument.  This patch uses this argument on every occurrence of add_llvm_library() in llvm.  This should greatly increase the number of header files in your IDE project and make source code browsing generally more pleasant.

I did measure a project load time increase of about 10% on Windows with MSVC 2013.  I think this is acceptable for MSVC, but would like some feedback from Xcode people to see if the situation is worse there.

http://reviews.llvm.org/D7526

Files:
  lib/Analysis/CMakeLists.txt
  lib/AsmParser/CMakeLists.txt
  lib/Bitcode/Reader/CMakeLists.txt
  lib/CodeGen/CMakeLists.txt
  lib/DebugInfo/DWARF/CMakeLists.txt
  lib/DebugInfo/PDB/CMakeLists.txt
  lib/ExecutionEngine/CMakeLists.txt
  lib/ExecutionEngine/Orc/CMakeLists.txt
  lib/IR/CMakeLists.txt
  lib/IRReader/CMakeLists.txt
  lib/LTO/CMakeLists.txt
  lib/LineEditor/CMakeLists.txt
  lib/Linker/CMakeLists.txt
  lib/MC/CMakeLists.txt
  lib/MC/MCParser/CMakeLists.txt
  lib/Object/CMakeLists.txt
  lib/Option/CMakeLists.txt
  lib/ProfileData/CMakeLists.txt
  lib/Support/CMakeLists.txt
  lib/TableGen/CMakeLists.txt
  lib/Target/CMakeLists.txt
  lib/Transforms/IPO/CMakeLists.txt
  lib/Transforms/InstCombine/CMakeLists.txt
  lib/Transforms/Instrumentation/CMakeLists.txt
  lib/Transforms/ObjCARC/CMakeLists.txt
  lib/Transforms/Scalar/CMakeLists.txt
  lib/Transforms/Utils/CMakeLists.txt
  lib/Transforms/Vectorize/CMakeLists.txt

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7526.19640.patch
Type: text/x-patch
Size: 10372 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150210/6fbec702/attachment.bin>


More information about the llvm-commits mailing list