[llvm] r228637 - [Orc] Back out one of the GCC ICE workarounds from r228568. NFC.

David Blaikie dblaikie at gmail.com
Mon Feb 9 17:12:41 PST 2015


On Mon, Feb 9, 2015 at 4:37 PM, Lang Hames <lhames at gmail.com> wrote:

> Author: lhames
> Date: Mon Feb  9 18:37:26 2015
> New Revision: 228637
>
> URL: http://llvm.org/viewvc/llvm-project?rev=228637&view=rev
> Log:
> [Orc] Back out one of the GCC ICE workarounds from r228568. NFC.
>

So the end conclusion was that you only needed to add the explicit "this->"
when you had some by-ref captures? (or default by-ref capture, I suppose?)


>
>
> Modified:
>     llvm/trunk/include/llvm/ExecutionEngine/Orc/ObjectLinkingLayer.h
>
> Modified: llvm/trunk/include/llvm/ExecutionEngine/Orc/ObjectLinkingLayer.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/ObjectLinkingLayer.h?rev=228637&r1=228636&r2=228637&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/ExecutionEngine/Orc/ObjectLinkingLayer.h
> (original)
> +++ llvm/trunk/include/llvm/ExecutionEngine/Orc/ObjectLinkingLayer.h Mon
> Feb  9 18:37:26 2015
> @@ -224,8 +224,8 @@ public:
>          [this, Addr, H](){
>            if (H->NeedsFinalization()) {
>              H->Finalize();
> -            if (this->NotifyFinalized)
> -              this->NotifyFinalized(H);
> +            if (NotifyFinalized)
> +              NotifyFinalized(H);
>            }
>            return Addr;
>          });
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150209/9afa30b4/attachment.html>


More information about the llvm-commits mailing list