[PATCH] Driver: Replace switch cases with ifs.

Rui Ueyama ruiu at google.com
Mon Feb 9 15:41:20 PST 2015


That's what I wanted to ask you. We didn't have this gigantic switch and
lots of break's there but a series of small ifs. You did converted them as
a part of unrelated change (which is the large InputGraph patch) without
any explanation. Yes, the original code looks better to me, and I guess
that's at least part of the reason why the original code was written as it
was. I'm basically trying to restore the original code.

On Fri, Feb 6, 2015 at 7:40 PM, Shankar Kalpathi Easwaran <
shankarke at gmail.com> wrote:

> I really dont understand, Its a matter of style, every developer may
> choose to follow different styles. Nothing is written in the coding
> convention document about what style to choose over another.
>
>
> http://reviews.llvm.org/D7478
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150209/61119b45/attachment.html>


More information about the llvm-commits mailing list