[PATCH] SelectionDAG: fold (fp_to_u/sint (u/sint_to_fp val)) when possible

Fiona Glaser fglaser at apple.com
Mon Feb 9 13:59:47 PST 2015


> On Feb 9, 2015, at 1:47 PM, Quentin Colombet <qcolombet at apple.com> wrote:
> 
> 
> On Feb 9, 2015, at 1:44 PM, Fiona Glaser <fglaser at apple.com <mailto:fglaser at apple.com>> wrote:
> 
>>>> 
>>>> Target-specific expansion or combine can end-up with this situation when it was not catched by ints-combine.
>>>> 
>>>> So I believe we want it to be done *both* in inst-combine *and* in the DAG.
>>> 
>>> I agree. That is also what I meant in my initial message.
>>> 
>>> Cheers,
>>> Q.
>> 
>> Okay, should I merge the two patches then (and maybe include both tests)?
> 
> Definitely include both tests :), but I’d rather have two different patches.

In that case, are the last versions of each of the patches in this thread (the DAG and instcombine ones) okay?

Fiona
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150209/03631eef/attachment.html>


More information about the llvm-commits mailing list