[PATCH] [lld][ELF][ARM] Add veneer generation to branch instructions

Rui Ueyama ruiu at google.com
Mon Feb 9 10:31:07 PST 2015


LGTM


================
Comment at: lib/ReaderWriter/ELF/ARM/ARMRelocationPass.cpp:40
@@ +39,3 @@
+    0x00, 0x00, 0x00,
+    0x00              // <target_symbol_address>
+};
----------------
The address is four byte right? I'd move this 0x00 and the comment to end of the previous line.

http://reviews.llvm.org/D7502

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list