[PATCH] Don't generate crash report when inline asm can't be parsed
Steven Wu
stevenwu at apple.com
Sun Feb 8 11:02:58 PST 2015
I think my patch only disable the crash report when Parser->run returns error in EmitInlineAsm. It is not related to what input type is. Is there any circumstance when it is a compiler crash when Parser->run returns error?
I thought about putting a error handler in clang but I don’t think clang can emit any diagnostics that is more helpful than backend.
> On Feb 7, 2015, at 9:38 PM, Eric Christopher <echristo at gmail.com> wrote:
>
> Not sure I agree with this - it changes the behavior (crash or not) based on whether or not there's bitcode as the input. There are lots of places that the behavior will continue as crashing. I think what should happen if you don't want this type of behavior is to avoid setting a global error handler via clang.
>
> Thoughts? More explanation on your logic?
>
> -eric
>
>
> http://reviews.llvm.org/D7476
>
> EMAIL PREFERENCES
> http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
More information about the llvm-commits
mailing list