[PATCH] Driver: Replace switch cases with ifs.

Rui Ueyama ruiu at google.com
Fri Feb 6 16:42:40 PST 2015


Hi shankarke,

We used to do like this instead of putting all command line processing
code within one gigantic switch statement. It is converted to a switch
in r188958, which introduced InputGraph.

Making bunch of ifs to one switch statement with bunch of cases weren't
needed for InputGraph, so I don't know why that change was made in the
first place.

In this patch I roll that change back. Now all "break"s are removed,
and the nesting is one level shallow.

http://reviews.llvm.org/D7478

Files:
  lib/Driver/WinLinkDriver.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7478.19518.patch
Type: text/x-patch
Size: 25935 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150207/58e0e6eb/attachment.bin>


More information about the llvm-commits mailing list