[PATCH] IR: Allow 32-bits for lines in debug location

[Sean Silva]

On Fri, Feb 6, 2015 at 2:31 PM, Eric Christopher <echristo at gmail.com> wrote:

> As long as it doesn't bloat size let's go for it. The original limitation
> was so that column and line would fit into a single 32-bits.
>

IIRC clang's SourceLocation is only 32 bits anyway, so theoretically that
should be all we need (I assume other language frontends will have less
extreme requirements w.r.t. source locations than clang).

-- Sean Silva


>
>
> -eric
>
> On Fri Feb 06 2015 at 2:26:22 PM Duncan P. N. Exon Smith <
> dexonsmith at apple.com> wrote:
>
>> Remove unnecessary restriction of 32-bits for line numbers in
>> `MDLocation`.
>>
>> The rest of the debug info schema (with the exception of local
>> variables) uses 32-bits for line numbers.  As I introduce the
>> specialized nodes, it makes sense to canonicalize on one size or the
>> other.
>>
>> Does this make sense to you folks, or would you rather canonicalize
>> on 24-bits?
>>
>>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150206/97d14be2/attachment.html>