[PATCH] Use ".arch_extension" ARM directive to specify the additional CPU features

Sumanth Gundapaneni sgundapa at codeaurora.org
Fri Feb 6 14:10:04 PST 2015


================
Comment at: include/llvm/MC/MCStreamer.h:142
@@ -141,2 +141,3 @@
   virtual void emitArch(unsigned Arch);
+  virtual void emitArchExtension(StringRef StringValue);
   virtual void emitObjectArch(unsigned Arch);
----------------
t.p.northover wrote:
> I think this either needs a generic implementation, or (probably better for now) moving to ARMELFStreamer.cpp entirely. OK, so it's not called, but 
p

================
Comment at: include/llvm/MC/MCStreamer.h:142
@@ -141,2 +141,3 @@
   virtual void emitArch(unsigned Arch);
+  virtual void emitArchExtension(StringRef StringValue);
   virtual void emitObjectArch(unsigned Arch);
----------------
t.p.northover wrote:
> rengolin wrote:
> > sgundapa wrote:
> > > t.p.northover wrote:
> > > > I think this either needs a generic implementation, or (probably better for now) moving to ARMELFStreamer.cpp entirely. OK, so it's not called, but 
> > > p
> > ARMELFStreamer? But this is assembly only...
> Yep, but it's essentially en ELF-dialect assembly feature so the AsmStreamer seems to live in the same file.
A quick google on ".arch_extension" suggests that this directive is specific to ARM as.
It is fair to move it to the ARMELFStreamer.cpp file at this moment

http://reviews.llvm.org/D7316

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list