[PATCH] [Polly][Refactor] Use only one BlockGenerator for a SCoP

Johannes Doerfert doerfert at cs.uni-saarland.de
Fri Feb 6 06:30:54 PST 2015


Some notes.


================
Comment at: include/polly/CodeGen/BlockGenerators.h:69
@@ -68,2 +68,3 @@
 class BlockGenerator {
 public:
+  BlockGenerator(PollyIRBuilder &Builder, Pass *P, LoopInfo &LI,
----------------
I forgot to copy the @param declarionts here.

================
Comment at: include/polly/CodeGen/BlockGenerators.h:91
@@ -99,6 +90,3 @@
   IslExprBuilder *ExprBuilder;
-
-  BlockGenerator(PollyIRBuilder &B, ScopStmt &Stmt, Pass *P, LoopInfo &LI,
-                 ScalarEvolution &SE, __isl_keep isl_ast_build *Build,
-                 IslExprBuilder *ExprBuilder);
+  BasicBlock &EntryBB;
 
----------------
This is part of the next patch and will be removed.

http://reviews.llvm.org/D7467

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list