[PATCH] [ASan] Make BlockingMutex really linker initialized.

Yury Gribov y.gribov at samsung.com
Thu Feb 5 22:10:24 PST 2015


On 02/04/2015 07:23 PM, David Blaikie wrote:
> On Wed, Feb 4, 2015 at 3:56 AM, Yury Gribov <tetra2005 at gmail.com> wrote:
>
>>> Yes, I think enabling -Wglobal-constructors for ASan (and for all the
>> rest sanitizers) will be great.
>>
>>
>> FYI it was relatively easy to get this working on Linux (with ~500 lines
>> of changes). Unfortunately Windows compiler lacks too many necessary
>> features: explicit initialization of array members, constexpr, unrestricted
>> unions (all still missing in VS2013 and we still use VS2012). Having #if
>> WINDOWS all over the place isn't an option as well so I'm afraid we are out
>> of luck.
>>
>
> Perhaps there's a relatively small number of structures (probably
> templates) we could create to keep all of this logic (and Windows
> workarounds/suppressions) in one place so it could scale to all the use
> cases we have?

Thanks for the idea, I'll check this next week.

-Y




More information about the llvm-commits mailing list