[PATCH] Use ".arch_extension" ARM directive to specify the additional CPU features

Tim Northover t.p.northover at gmail.com
Thu Feb 5 19:30:25 PST 2015

Just a couple of minor points:

Comment at: include/llvm/MC/MCStreamer.h:142
@@ -141,2 +141,3 @@
   virtual void emitArch(unsigned Arch);
+  virtual void emitArchExtension(StringRef StringValue);
   virtual void emitObjectArch(unsigned Arch);
I think this either needs a generic implementation, or (probably better for now) moving to ARMELFStreamer.cpp entirely. OK, so it's not called, but 

Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:644
@@ -643,3 +643,1 @@
-  // FIXME: remove krait check when GNU tools support krait cpu
-  if (CPUString != "generic" && CPUString != "krait")
Any news on this, by the way? It's rather a horrific hack to have to carry, and it only seems to be getting worse.



More information about the llvm-commits mailing list