[PATCH] Add methods to get archive file name from member file

Rui Ueyama ruiu at google.com
Thu Feb 5 14:40:31 PST 2015

Comment at: lib/ReaderWriter/FileArchive.cpp:206
@@ -205,3 +205,3 @@
     result = std::move(files[0]);
     if (std::error_code ec = result->parse())
       return ec;
shankarke wrote:
> shankarke wrote:
> > There is still an issue that if there was a parse error, diagnostics will not show the proper error. Say the file was of a different architecture. I remember this was the reason I created ArchiveMemoryBuffer.
> What I meant here, is that diagnostics will not show the full path of the file, where there was an error.
Oh, that's too minor and edge case to justify creating a new subclass of MemoryBuffer. If we want to include archive file name, we can simply returns a new error message here.



More information about the llvm-commits mailing list