[PATCH] [lld] Add ArchiveMemoryBuffer.

[Rui Ueyama]

That string is only needed for debugging and logging, no? And it can be
constructed by file.archivePath() + "(" + file.path() + ")". Because both
archivePath and path are public functions, I'm not sure if we really need
the convenient member function just to concatenate the two strings. We can
instead concatenate the two strings at caller side.

That being said, if "archivefile(file)"-style string is needed in many
places, the convenient function would be actually convenient. I'll take a
look.

On Thu, Feb 5, 2015 at 12:45 PM, Shankar Kalpathi Easwaran <
shankarke at gmail.com> wrote:

> The file path is constructed as :- memberPath = archiveFileName + "(" +
> membername + ")";
>
> The archive filename is archiveFileName and the member that we are
> instantiating is memberName.
>
> For example :-
>
> memberPath has the value libc.a(printf.o) where archiveFileName is libc.a
> and memberName is printf.o
>
> Is this what you were looking for ?
>
>
> http://reviews.llvm.org/D7428
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150205/0019447c/attachment.html>