[PATCH] Canonicalize splats as build_vectors (PR22283)

[Andrea Di Biagio]

Hi Sanjay,

the patch LGTM.
However, somebody should review the codegen change in the ARM test.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1563
@@ +1562,3 @@
+
+        SDValue NewBV =getNode(ISD::BUILD_VECTOR, dl, BV->getValueType(0), Ops);
+
----------------
spatel wrote:
> mkuper wrote:
> > There's a missing space after the =.
> That was an 80-column hack...so close. :)
There are two places where we check for the BUILD_VECTOR value type. One is here at line 1563, the other one is at line 1567. If you evaluate 'BV->getValueType(0)' before the call to 'getNode' (line 1563), then you can reuse it and it will fit in the 80-cols.

http://reviews.llvm.org/D7389

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/