[llvm] r228055 - [x86] Fix signed vs. unsigned comparison.

Chandler Carruth chandlerc at gmail.com
Tue Feb 3 17:12:15 PST 2015

On Tue, Feb 3, 2015 at 4:23 PM, Craig Topper <craig.topper at gmail.com> wrote:

> Why is Size an int? Doesn't Mask.size() return an unsigned value? Is there
> later use that expects an int?

Heh, yes. See the other thread.

Fundamentally, unsigned isn't the right type here. We do subtraction,
sometimes we use them with other integers in a context that has -1 as a
meaningful value.

I really wish that the 'size()' methods and such returned some signed type
here, but oh well.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150203/12be309e/attachment.html>

More information about the llvm-commits mailing list