[llvm] r227074 - Fix a problem where the AArch64 ELF assembler was failing with

[NAKAMURA Takumi]

Eric, do you think test/MC/ELF/AArch64 (nonexistent in trunk) would be
an appropriate place?

2015-02-04 7:23 GMT+09:00 Eric Christopher <echristo at gmail.com>:
> Can we get the test back sometime? It was useful :)
>
> -eric
>
> On Tue Feb 03 2015 at 9:10:13 AM NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
>>
>> Sorry, I forgot to notice. It depended on targets_to_build.
>>
>> 2015-02-04 1:29 GMT+09:00 Rafael Espíndola <rafael.espindola at gmail.com>:
>> > Note that the test was reverted in r227080 and never added back.
>> >
>> > On 26 January 2015 at 01:32, Eric Christopher <echristo at gmail.com>
>> > wrote:
>> >> Author: echristo
>> >> Date: Mon Jan 26 00:32:17 2015
>> >> New Revision: 227074
>> >>
>> >> URL: http://llvm.org/viewvc/llvm-project?rev=227074&view=rev
>> >> Log:
>> >> Fix a problem where the AArch64 ELF assembler was failing with
>> >> -no-exec-stack. This was due to it not deriving from the correct
>> >> asm info base class and missing the override for the exec
>> >> stack section query. Added another line to the noexec test
>> >> line to make sure this doesn't regress.
>> >>
>> >> Modified:
>> >>     llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.h
>> >>     llvm/trunk/test/MC/ELF/noexec.s
>> >>
>> >> Modified: llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.h
>> >> URL:
>> >> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.h?rev=227074&r1=227073&r2=227074&view=diff
>> >>
>> >> ==============================================================================
>> >> --- llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.h
>> >> (original)
>> >> +++ llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.h Mon
>> >> Jan 26 00:32:17 2015
>> >> @@ -15,6 +15,7 @@
>> >>  #define LLVM_LIB_TARGET_AARCH64_MCTARGETDESC_AARCH64MCASMINFO_H
>> >>
>> >>  #include "llvm/MC/MCAsmInfoDarwin.h"
>> >> +#include "llvm/MC/MCAsmInfoELF.h"
>> >>
>> >>  namespace llvm {
>> >>  class Target;
>> >> @@ -27,7 +28,7 @@ struct AArch64MCAsmInfoDarwin : public M
>> >>                                MCStreamer &Streamer) const override;
>> >>  };
>> >>
>> >> -struct AArch64MCAsmInfoELF : public MCAsmInfo {
>> >> +struct AArch64MCAsmInfoELF : public MCAsmInfoELF {
>> >>    explicit AArch64MCAsmInfoELF(StringRef TT);
>> >>  };
>> >>
>> >>
>> >> Modified: llvm/trunk/test/MC/ELF/noexec.s
>> >> URL:
>> >> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ELF/noexec.s?rev=227074&r1=227073&r2=227074&view=diff
>> >>
>> >> ==============================================================================
>> >> --- llvm/trunk/test/MC/ELF/noexec.s (original)
>> >> +++ llvm/trunk/test/MC/ELF/noexec.s Mon Jan 26 00:32:17 2015
>> >> @@ -1,4 +1,5 @@
>> >>  // RUN: llvm-mc -no-exec-stack -filetype=obj -triple
>> >> x86_64-pc-linux-gnu %s -o - | llvm-readobj -s -t | FileCheck  %s
>> >> +// RUN: llvm-mc -no-exec-stack -filetype=obj -triple aarch64-linux-gnu
>> >> %s -o - | llvm-readobj -s -t | FileCheck %s
>> >>
>> >>  // CHECK:        Section {
>> >>  // CHECK:          Index: 4
>> >>
>> >>
>> >> _______________________________________________
>> >> llvm-commits mailing list
>> >> llvm-commits at cs.uiuc.edu
>> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits