[llvm] r221915 - Object, Mach-O: Refactor and clean code up

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Feb 3 13:27:14 PST 2015

On 26 January 2015 at 23:49, Lang Hames <lhames at gmail.com> wrote:
> Hi Guys,
> Yeah - this is definitely an improvement. Tests would be great though. It
> looks like we need a few malformed objects: (1) Duplicate SymtabLoadCmd, (2)
> Duplicate DysymtabLoadCmd, (3) Duplicate DataInCodeLoadCmd, (4) Duplicate
> DyldInfoLoadCmd, and (5) Duplicate UuidLoadCmd.
> I've filed http://llvm.org/PR22343 - if anyone wants to dive on it feel
> free, otherwise I'll try to get to it (time permitting) in the next few
> days.

lib/Object has a history of code that can never fail passing a EC
around for nothing. A "good" example was the old
"iterator.increment(EC)" instead of just "++iterator". This is why I
am not convinced that adding error handling to it without a
corresponding lit test is a good thing.


More information about the llvm-commits mailing list