[PATCH] Remove a gross usage of environment variables in MachineVerifier, replacing it with support for setting the -verify-machineinstrs flag via an environment variable in LIT.

Chandler Carruth chandlerc at gmail.com
Tue Feb 3 12:45:39 PST 2015


This looks great. Minor nit below, but submit whenever.


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/MachineVerifier.cpp:66
@@ -65,4 +65,3 @@
     const char *Banner;
-    const char *const OutFileName;
     raw_ostream *OS;
     const MachineFunction *MF;
----------------
>From the other review, make this a reference? (Maybe that doesn't work with some other constructor.

http://reviews.llvm.org/D7382

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list