[PATCH] SpecialCaseList: Add support for parsing multiple input files.

Peter Collingbourne peter at pcc.me.uk
Tue Feb 3 11:53:44 PST 2015


Can we add a test showing that reading special case lists from multiple files works correctly?


================
Comment at: bindings/go/llvm/InstrumentationBindings.cpp:43
@@ +42,3 @@
+  std::vector<std::string> ABIListFilesVec;
+  for (int i = 0, n = ABIListFilesNum; i < n; ++i) {
+    ABIListFilesVec.push_back(ABIListFiles[i]);
----------------
Nit: `i != ABIListFilesNum`

================
Comment at: bindings/go/llvm/transforms_instrumentation.go:46
@@ -43,1 +45,3 @@
+        C.LLVMAddDataFlowSanitizerPass(pm.C, C.int(len(abilist)),
+                                       &abiliststrs[0])
 }
----------------
Nit: indentation doesn't look right here.

http://reviews.llvm.org/D7367

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list