[PATCH] Add a 'no-asserts' requirement option to LIT.

[David Blaikie]

On Tue, Feb 3, 2015 at 11:03 AM, Owen Anderson <resistor at mac.com> wrote:

> Hi chandlerc, joker.eph,
>
> This is useful when checking diagnostics and annotations that are only
> enabled in asserts mode.


Not sure I quite follow - "REQUIRES: Asserts" would be used for any test
case that's verifying a failure that's only enabled in asserts mode.
"REQUIRES: no-asserts" would be for testing the absence of that same
failure in a no-asserts build?

That seems like a thing I wouldn't want to test for. The idea is that the
program has undefined behavior if it would assert but you're in a
non-asserts build. That's not a thing to test for - there's no
specific/guaranteed behavior in that case.


> Today we can only test the positive case (when asserts are enabled) but
> not the negative case.
>
> REPOSITORY
>   rL LLVM
>
> http://reviews.llvm.org/D7383
>
> Files:
>   test/lit.cfg
>
> Index: test/lit.cfg
> ===================================================================
> --- test/lit.cfg
> +++ test/lit.cfg
> @@ -370,6 +370,8 @@
>
>  if re.search(r'ON', llvm_config_cmd.stdout.read().decode('ascii')):
>      config.available_features.add('asserts')
> +else:
> +    config.available_features.add('no-asserts')
>  llvm_config_cmd.wait()
>
>  if 'darwin' == sys.platform:
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150203/6feb532a/attachment.html>