[PATCH] Add a 'no-asserts' requirement option to LIT.
dblaikie at gmail.com
Tue Feb 3 11:15:06 PST 2015
On Tue, Feb 3, 2015 at 11:03 AM, Owen Anderson <resistor at mac.com> wrote:
> Hi chandlerc, joker.eph,
> This is useful when checking diagnostics and annotations that are only
> enabled in asserts mode.
Not sure I quite follow - "REQUIRES: Asserts" would be used for any test
case that's verifying a failure that's only enabled in asserts mode.
"REQUIRES: no-asserts" would be for testing the absence of that same
failure in a no-asserts build?
That seems like a thing I wouldn't want to test for. The idea is that the
program has undefined behavior if it would assert but you're in a
non-asserts build. That's not a thing to test for - there's no
specific/guaranteed behavior in that case.
> Today we can only test the positive case (when asserts are enabled) but
> not the negative case.
> rL LLVM
> Index: test/lit.cfg
> --- test/lit.cfg
> +++ test/lit.cfg
> @@ -370,6 +370,8 @@
> if re.search(r'ON', llvm_config_cmd.stdout.read().decode('ascii')):
> + config.available_features.add('no-asserts')
> if 'darwin' == sys.platform:
> EMAIL PREFERENCES
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits