[PATCH] [Bitcode reader] Fix a few assertions when reading invalid files
filcab+llvm.phabricator at gmail.com
Mon Feb 2 15:25:13 PST 2015
For now I'm still making sure we don't assert on stuff.
We can eventually add the Diag-style error handling, but that'll end up
“just” transforming these fixes I'm doing, it won't change them, so I'm
continuing to go through my set of inputs that crash the reader.
These ones also end up using the error reporting that was already there, so
it's not like they're report_fatal_error() calls. They actually tell the
caller that there was an error and it can do something (but not that much)
I might end up starting doing the Diag-style patch soon, but it depends on
the other work I have to do. In the meantime I'll keep going over the crash
fixes, since most of those are small-ish patches. (Unless there are
objections to me doing it now)
On Mon, Feb 2, 2015 at 3:12 PM, Sean Silva <chisophugis at gmail.com> wrote:
> are you ever planning on switching over to a more "diag" style interface
> like Rafael suggested? That would allow making these errors much more
> EMAIL PREFERENCES
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits