[PATCH] [ELF] Support for parsing OUTPUT command in LinkerScript

Davide Italiano davide at freebsd.org
Sun Feb 1 20:44:33 PST 2015

In http://reviews.llvm.org/D7326#116598, @ruiu wrote:

> It basically looks good, but we already have a large piece of code as a part of the linker script parser which don't have any consumer. This patch adds a parser for OUTPUT() but you didn't make any change to use or interpret that directive. So, the new code doesn't actually provide value to the user by itself. It's also a little bit concerning -- there might be a design flaw that's only noticeable when we try to use the parser.
> Could you update the GNU driver to consume OUTPUT directive?

My plan was to split parsing and action, i.e. to implement the latter in a subsequent commit (was planning to do this tonight or tomorrow). If you have any concern I can incorporate the driver update in this change but I don't see a strong reason why they can't be committed as standalone changes. Let me know what you think about it.



More information about the llvm-commits mailing list