[PATCH] [ELF] Support for parsing OUTPUT command in LinkerScript
Shankar Kalpathi Easwaran
shankarke at gmail.com
Sun Feb 1 19:21:08 PST 2015
Comment at: include/lld/ReaderWriter/LinkerScript.h:190
@@ +189,3 @@
+ StringRef _outputFileName;
I have one main comment generally with the linker script parser as to we store all the data from linker scripts as StringRef's. We dont need to keep the linker script file open IMO, so using std::string would be better.
What do you think ?
More information about the llvm-commits