[PATCH] [fuzzer] Add a gtest-style test

Alexey Samsonov vonosmas at gmail.com
Fri Jan 30 15:11:58 PST 2015


LGTM, after addressing two nits below.


================
Comment at: lib/Fuzzer/test/CMakeLists.txt:59
@@ -34,3 +58,3 @@
     ${CMAKE_CURRENT_BINARY_DIR}
-    DEPENDS ${TestBinaries}
+    DEPENDS ${TestBinaries} LLVMFuzzer-Unittest
     )
----------------
just ${TestBinaries} here.

================
Comment at: lib/Fuzzer/test/FuzzerUnittest.cpp:6
@@ +5,3 @@
+// For now, have TestOneInput just to make it link.
+// Later may want to make unittests that actuall call TestOneInput.
+extern "C" void TestOneInput(const uint8_t *Data, size_t Size) {
----------------
s/may/we may
s/actuall/actually

http://reviews.llvm.org/D7287

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list