[PATCH] [ASan] Make BlockingMutex really linker initialized.

Alexey Samsonov vonosmas at gmail.com
Fri Jan 30 12:14:32 PST 2015


> Ok, it turned out to be more interesting than I expected. We clone a lock-owning thread in StopTheWorld and then call CheckLocked in the clone (assuming that it "inherited" the lock). This obviously fails because owner_ field does not match. So looks like the whole idea of owner_ conflicts with our lock-passing semantics. I wonder if it's better to remove it altogether (at least on Linux and Mac, Windows uses it for some other purpose).


+gilder

Fun. I'm fine with removing owner_ field on Linux and Mac, but we'll need to implement BlockingMutex::CheckLocked() in this case somehow.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7171

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list