[llvm] r227584 - ARM: correct handling of .fpu directive
hans at chromium.org
Fri Jan 30 10:46:16 PST 2015
On Fri, Jan 30, 2015 at 10:28 AM, Saleem Abdulrasool
<compnerd at compnerd.org> wrote:
> On Fri, Jan 30, 2015 at 10:20 AM, Hans Wennborg <hans at chromium.org> wrote:
>> On Fri, Jan 30, 2015 at 9:58 AM, Saleem Abdulrasool
>> <compnerd at compnerd.org> wrote:
>> > Author: compnerd
>> > Date: Fri Jan 30 11:58:25 2015
>> > New Revision: 227584
>> > URL: http://llvm.org/viewvc/llvm-project?rev=227584&view=rev
>> > Log:
>> > ARM: correct handling of .fpu directive
>> > The FPU directive permits the user to switch the target FPU, enabling
>> > instructions that would be otherwise unavailable. However, when
>> > configuring the
>> > new subtarget features, we would not enable the implied functions for
>> > newer
>> > FPUs. This would result in invalid rejection of valid input. Ensure
>> > that we
>> > inherit the implied FPU functionality when enabling newer versions of
>> > the FPU.
>> > Fortunately, these are mostly hierarchical, unlike the CPUs.
>> > Addresses PR22395.
>> Should we merge this to 3.6?
> Good call, I think that is a good idea.
Tim, what do you think?
More information about the llvm-commits