[PATCH] [LoopVectorize] Pass parameters explicitly to MemoryDepChecker

[Adam Nemet]

> On Jan 30, 2015, at 10:25 AM, Hal Finkel <hfinkel at anl.gov> wrote:
> 
> ----- Original Message -----
>> From: "Adam Nemet" <anemet at apple.com>
>> To: anemet at apple.com, aschwaighofer at apple.com, hfinkel at anl.gov
>> Cc: llvm-commits at cs.uiuc.edu
>> Sent: Friday, January 30, 2015 12:01:32 PM
>> Subject: Re: [PATCH] [LoopVectorize] Pass parameters explicitly to MemoryDepChecker
>> 
>> In http://reviews.llvm.org/D7284#115788, @hfinkel wrote:
>> 
>>> I think it would be better to collect these into a struct
>>> describing vectorization thresholds.
>> 
>> 
>> Sure, I can do that.  (I was going to wait and see how this shapes up
>> with LoopDist as another client.  The MemoryDepChecker would have to
>> somehow be specialized further for the Vectorizer.)
> 
> Understood; but I think you might as well do that now. We can always refactor things again later.

Yeah sure, I am not arguing, I think what you say makes sense even in the long term.   I just wanted to take a chance to explain where I was going with some of this.

Thanks for all the reviews!

Adam

> 
> -Hal
> 
>> 
>> 
>> http://reviews.llvm.org/D7284
>> 
>> EMAIL PREFERENCES
>>  http://reviews.llvm.org/settings/panel/emailpreferences/
>> 
>> 
>> 
> 
> -- 
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory