[PATCH] Change clang driver to pass -target-abi option

Daniel Sanders daniel.sanders at imgtec.com
Fri Jan 30 08:08:59 PST 2015

LGTM. The passing of -target-abi ought to be generic given that the backend handling is generic but this is still good as-is since it will silence the unknown feature warnings coming from the backend and fixing that is fairly urgent.

Comment at: lib/Driver/Tools.cpp:4868
@@ +4867,3 @@
+void ClangAs::AddMIPSTargetArgs(const ArgList &Args,
+                              ArgStringList &CmdArgs) const {
+  StringRef CPUName;
Nit: Indentation

Comment at: lib/Driver/Tools.cpp:4985
@@ -4984,1 +4984,3 @@
+    // Add target specific flags.
+  switch(getToolChain().getArch()) {
Nit: Indentation



More information about the llvm-commits mailing list