[PATCH] Move DebugInfo to DebugInfo/DWARF

[Frédéric Riss]

> On Jan 29, 2015, at 2:36 PM, Zachary Turner <zturner at google.com> wrote:
> 
> Hi aprantl, echristo, dblaikie, friss,
> 
> In preparation for adding PDB support to LLVM, this moves the DWARF parsing code to its own subdirectory under DebugInfo, and renames LLVMDebugInfo to LLVMDebugInfoDWARF.
> 
> This is purely a mechanical / build system change.
> 
> I successfully built LLVM using CMake and ninja check-llvm returned no failures.
> 
> I'm not able to test the make/autoconf build, but I did update the relevant Makefiles, so I believe it should work.

Why aren’t you able to do a configure/make build? 

> [BTW, I know Frederic said he's working on a change that may conflict with this.  I'm happy to wait until that change is in if people desire, but this was pretty mechanical and quick to whip up, so figured I would put it up in the meantime rather than wait around and do nothing :)]

Don’t worry about that, this should not slow you down. Moving the files is easy enough.

> http://reviews.llvm.org/D7269
> 
> Files:
>  include/llvm/DebugInfo/DIContext.h
>  include/llvm/DebugInfo/DWARF/DIContext.h
>  include/llvm/DebugInfo/DWARF/DWARFAbbreviationDeclaration.h

I don’t know what LLVM’s policy is with respect to include hierarchy and libraries. The name of the files here already nicely create a namespace. If there’s no policy requiring the separate directory, I think I’d slightly prefer to leave all the includes in include/llvm/DebugInfo/ and add the PDB ones in the same place with a PDB prefix. It would also make the patch much smaller.

Opinions?

Fred

>  include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h
>  include/llvm/DebugInfo/DWARF/DWARFCompileUnit.h
>  include/llvm/DebugInfo/DWARF/DWARFContext.h
>  include/llvm/DebugInfo/DWARF/DWARFDebugAbbrev.h
>  include/llvm/DebugInfo/DWARF/DWARFDebugArangeSet.h
>  include/llvm/DebugInfo/DWARF/DWARFDebugAranges.h
>  include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h
>  include/llvm/DebugInfo/DWARF/DWARFDebugInfoEntry.h
>  include/llvm/DebugInfo/DWARF/DWARFDebugLine.h
>  include/llvm/DebugInfo/DWARF/DWARFDebugLoc.h
>  include/llvm/DebugInfo/DWARF/DWARFDebugRangeList.h
>  include/llvm/DebugInfo/DWARF/DWARFFormValue.h
>  include/llvm/DebugInfo/DWARF/DWARFRelocMap.h
>  include/llvm/DebugInfo/DWARF/DWARFSection.h
>  include/llvm/DebugInfo/DWARF/DWARFTypeUnit.h
>  include/llvm/DebugInfo/DWARF/DWARFUnit.h
>  include/llvm/DebugInfo/DWARFAbbreviationDeclaration.h
>  include/llvm/DebugInfo/DWARFAcceleratorTable.h
>  include/llvm/DebugInfo/DWARFCompileUnit.h
>  include/llvm/DebugInfo/DWARFContext.h
>  include/llvm/DebugInfo/DWARFDebugAbbrev.h
>  include/llvm/DebugInfo/DWARFDebugArangeSet.h
>  include/llvm/DebugInfo/DWARFDebugAranges.h
>  include/llvm/DebugInfo/DWARFDebugFrame.h
>  include/llvm/DebugInfo/DWARFDebugInfoEntry.h
>  include/llvm/DebugInfo/DWARFDebugLine.h
>  include/llvm/DebugInfo/DWARFDebugLoc.h
>  include/llvm/DebugInfo/DWARFDebugRangeList.h
>  include/llvm/DebugInfo/DWARFFormValue.h
>  include/llvm/DebugInfo/DWARFRelocMap.h
>  include/llvm/DebugInfo/DWARFSection.h
>  include/llvm/DebugInfo/DWARFTypeUnit.h
>  include/llvm/DebugInfo/DWARFUnit.h
>  lib/DebugInfo/CMakeLists.txt
>  lib/DebugInfo/DIContext.cpp
>  lib/DebugInfo/DWARF/CMakeLists.txt
>  lib/DebugInfo/DWARF/DIContext.cpp
>  lib/DebugInfo/DWARF/DWARFAbbreviationDeclaration.cpp
>  lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp
>  lib/DebugInfo/DWARF/DWARFCompileUnit.cpp
>  lib/DebugInfo/DWARF/DWARFContext.cpp
>  lib/DebugInfo/DWARF/DWARFDebugAbbrev.cpp
>  lib/DebugInfo/DWARF/DWARFDebugArangeSet.cpp
>  lib/DebugInfo/DWARF/DWARFDebugAranges.cpp
>  lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
>  lib/DebugInfo/DWARF/DWARFDebugInfoEntry.cpp
>  lib/DebugInfo/DWARF/DWARFDebugLine.cpp
>  lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
>  lib/DebugInfo/DWARF/DWARFDebugRangeList.cpp
>  lib/DebugInfo/DWARF/DWARFFormValue.cpp
>  lib/DebugInfo/DWARF/DWARFTypeUnit.cpp
>  lib/DebugInfo/DWARF/DWARFUnit.cpp
>  lib/DebugInfo/DWARF/LLVMBuild.txt
>  lib/DebugInfo/DWARF/Makefile
>  lib/DebugInfo/DWARF/SyntaxHighlighting.cpp
>  lib/DebugInfo/DWARF/SyntaxHighlighting.h
>  lib/DebugInfo/DWARF/module.modulemap
>  lib/DebugInfo/DWARFAbbreviationDeclaration.cpp
>  lib/DebugInfo/DWARFAcceleratorTable.cpp
>  lib/DebugInfo/DWARFCompileUnit.cpp
>  lib/DebugInfo/DWARFContext.cpp
>  lib/DebugInfo/DWARFDebugAbbrev.cpp
>  lib/DebugInfo/DWARFDebugArangeSet.cpp
>  lib/DebugInfo/DWARFDebugAranges.cpp
>  lib/DebugInfo/DWARFDebugFrame.cpp
>  lib/DebugInfo/DWARFDebugInfoEntry.cpp
>  lib/DebugInfo/DWARFDebugLine.cpp
>  lib/DebugInfo/DWARFDebugLoc.cpp
>  lib/DebugInfo/DWARFDebugRangeList.cpp
>  lib/DebugInfo/DWARFFormValue.cpp
>  lib/DebugInfo/DWARFTypeUnit.cpp
>  lib/DebugInfo/DWARFUnit.cpp
>  lib/DebugInfo/LLVMBuild.txt
>  lib/DebugInfo/Makefile
>  lib/DebugInfo/SyntaxHighlighting.cpp
>  lib/DebugInfo/SyntaxHighlighting.h
>  lib/DebugInfo/module.modulemap
>  lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp
>  lib/ExecutionEngine/IntelJITEvents/LLVMBuild.txt
>  lib/Makefile
>  tools/dsymutil/CMakeLists.txt
>  tools/dsymutil/DwarfLinker.cpp
>  tools/dsymutil/LLVMBuild.txt
>  tools/dsymutil/Makefile
>  tools/llvm-dwarfdump/CMakeLists.txt
>  tools/llvm-dwarfdump/LLVMBuild.txt
>  tools/llvm-dwarfdump/Makefile
>  tools/llvm-dwarfdump/llvm-dwarfdump.cpp
>  tools/llvm-objdump/CMakeLists.txt
>  tools/llvm-objdump/LLVMBuild.txt
>  tools/llvm-objdump/MachODump.cpp
>  tools/llvm-objdump/Makefile
>  tools/llvm-rtdyld/CMakeLists.txt
>  tools/llvm-rtdyld/Makefile
>  tools/llvm-rtdyld/llvm-rtdyld.cpp
>  tools/llvm-symbolizer/CMakeLists.txt
>  tools/llvm-symbolizer/LLVMSymbolize.h
>  tools/llvm-symbolizer/Makefile
>  unittests/DebugInfo/CMakeLists.txt
>  unittests/DebugInfo/DWARFFormValueTest.cpp
>  unittests/DebugInfo/Makefile
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> <D7269.18990.patch>