[PATCH] Extend s{, n}printf custom wrappers to support '*' in the format specifiers

Peter Collingbourne peter at pcc.me.uk
Thu Jan 29 13:54:39 PST 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/dfsan/dfsan_custom.cc:971
@@ +970,3 @@
+                       format_size + 1, va_arg(ap, t))
+#define LABEL_CHUNK(l)                                                         \
+      dfsan_set_label(l, str + off,                                            \
----------------
I feel a little uncomfortable about introducing more of these macros. Can we perhaps introduce a struct to hold the state used by these functions and make these macros and the functions into methods of the struct?

http://reviews.llvm.org/D7249

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list