[PATCH] Work around ppc64 TLS linker bug (Re: [LPM] Try again to appease powerpc64 in its self host.)

Ulrich Weigand Ulrich.Weigand at de.ibm.com
Thu Jan 29 11:12:38 PST 2015


Hal Finkel <hfinkel at anl.gov> wrote on 29.01.2015 19:37:31:

> > I'm not completely sure if this is the correct place to add this,
> > but the patch seems to work for me.  With this clang patch, I'm
> > able to successfully bootstrap clang again (with the initial-exec
> > TLS attribute in Chandler's latest change removed again).
> >
> > OK to check in?
> >
> > (See attached file: clang-ppc64-notlsopt.patch)
>
> Yes, LGTM. We do need a test case, however (I think that something
> like test/Driver/Xlinker-args.c is essentially what is needed).

I've added a check to test/Driver/ppc-features.cpp which did already
check for linker options on PowerPC.  Checked in as r227480.

Chandler, it would probably be best to remove the initial-exec
TLS model attribute again now that we use --no-tls-optimize ...

Bye,
Ulrich




More information about the llvm-commits mailing list