PATCH: Don't warn if bash is missing

Aaron Ballman aaron at aaronballman.com
Thu Jan 29 10:45:54 PST 2015


On Thu, Jan 29, 2015 at 1:19 PM, Edwards, Michael
<Michael_Edwards at playstation.sony.com> wrote:
> Hi,
>
>
> It looks like bash will always be available on the supported platforms
> except Windows.  In Windows we can run the tests without bash.  I'm hoping
> we can remove this warning as it is causing my Buildbots to remain yellow
> all the time.  I'm not sure if it is needed anywhere else?

I would love to see that warning go away, and this patch LGTM, but you
should wait for someone more Lit-savvy to agree before committing.

I'm not certain if this affects your bots or not, but when I test
locally, I usually wind up with:

60>  lit.py: LitConfig.py:94: note: Unable to find 'bash.exe'.
60>  lit.py: lit.cfg:195: note: using clang: 'E:/llvm/2013/Debug/bin/clang.EXE'
60>  lit.py: lit.cfg:333: note: Did not find clang-interpreter in
E:/llvm/2013/Debug/bin;E:/llvm/2013/Debug/bin
60>  lit.py: LitConfig.py:94: note: Unable to find 'bash.exe'.
60>  lit.py: lit.cfg:271: note: Did not find llvm-go in E:/llvm/2013/Debug/bin

Do you see the other notes as well?

~Aaron



More information about the llvm-commits mailing list