[PATCH] New "strict_string_checks" run-time flag

Maria Guseva m.guseva at samsung.com
Thu Jan 29 07:38:35 PST 2015

In http://reviews.llvm.org/D7123#114488, @glider wrote:

> A couple of ideas how we can proceed with the tests:
> 1. make UnitTests extract |strict_string_checks| from ASAN_OPTIONS and fix the checks to behave based on that setting;
> 2. remove the failing checks from the test suite and write the corresponding lit tests that will test both strict_string_checks modes (or drop them if they're covered by the tests you've added in this CL);
> 3. fix the failing checks assuming that strict_string_checks is always on.

I would prefer the second variant. If no objections or other ideas I'll prepare corresponding update for this patch.

Comment at: test/asan/TestCases/atol_strict.c:3
@@ +2,3 @@
+// RUN: %clang_asan %s -o %t && not %run %t 2>&1 | FileCheck %s
+// RUN: ASAN_OPTIONS=strict_string_checks=false %run %t 2>&1
+// RUN: ASAN_OPTIONS=strict_string_checks=true not %run %t 2>&1 | FileCheck %s
kcc wrote:
> here and below, add a 3-rd RUN line to run w/o ASAN_OPTIONS (i.e. to test what's default)
Isn't it in first line after compile or do you mean something else?



More information about the llvm-commits mailing list