[PATCH] Remove unused tokens from AsmParser.

Robin Eklind up752724 at myport.ac.uk
Thu Jan 29 04:45:22 PST 2015


Hi silvas,

The tokens hash and backslash seems to be historical artefacts and are not used anywhere else in the LLVM code base. The LLVM tree (rev 227402) builds just fine with this patch applied and the test cases pass:

Testing Time: 1921.21s
  Expected Passes    : 12203
  Expected Failures  : 87
  Unsupported Tests  : 73

Reference discussion: https://groups.google.com/forum/#!topic/llvm-dev/CcJZnpRXWdE

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7248

Files:
  lib/AsmParser/LLLexer.cpp
  lib/AsmParser/LLToken.h

Index: lib/AsmParser/LLLexer.cpp
===================================================================
--- lib/AsmParser/LLLexer.cpp
+++ lib/AsmParser/LLLexer.cpp
@@ -241,7 +241,6 @@
   case ')': return lltok::rparen;
   case ',': return lltok::comma;
   case '*': return lltok::star;
-  case '\\': return lltok::backslash;
   }
 }
 
Index: lib/AsmParser/LLToken.h
===================================================================
--- lib/AsmParser/LLToken.h
+++ lib/AsmParser/LLToken.h
@@ -28,9 +28,7 @@
     lbrace, rbrace,    // {  }
     less, greater,     // <  >
     lparen, rparen,    // (  )
-    backslash,         // \    (not /)
     exclaim,           // !
-    hash,              // #
 
     kw_x,
     kw_true,    kw_false,

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7248.18952.patch
Type: text/x-patch
Size: 739 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150129/e7d4fb28/attachment.bin>


More information about the llvm-commits mailing list