[llvm] r227355 - invert check for less indentation; use local vars to reduce duplication; NFC

Sanjay Patel spatel at rotateright.com
Wed Jan 28 11:44:22 PST 2015


Author: spatel
Date: Wed Jan 28 13:44:21 2015
New Revision: 227355

URL: http://llvm.org/viewvc/llvm-project?rev=227355&view=rev
Log:
invert check for less indentation; use local vars to reduce duplication; NFC

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=227355&r1=227354&r2=227355&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Wed Jan 28 13:44:21 2015
@@ -13197,27 +13197,28 @@ static SDValue LowerEXTRACT_SUBVECTOR(SD
 // the upper bits of a vector.
 static SDValue LowerINSERT_SUBVECTOR(SDValue Op, const X86Subtarget *Subtarget,
                                      SelectionDAG &DAG) {
-  if (Subtarget->hasFp256()) {
-    SDLoc dl(Op);
-    SDValue Vec = Op.getOperand(0);
-    SDValue SubVec = Op.getOperand(1);
-    SDValue Idx = Op.getOperand(2);
-
-    if ((Op.getSimpleValueType().is256BitVector() ||
-         Op.getSimpleValueType().is512BitVector()) &&
-        SubVec.getSimpleValueType().is128BitVector() &&
-        isa<ConstantSDNode>(Idx)) {
-      unsigned IdxVal = cast<ConstantSDNode>(Idx)->getZExtValue();
-      return Insert128BitVector(Vec, SubVec, IdxVal, DAG, dl);
-    }
+  if (!Subtarget->hasAVX())
+    return SDValue();
+  
+  SDLoc dl(Op);
+  SDValue Vec = Op.getOperand(0);
+  SDValue SubVec = Op.getOperand(1);
+  SDValue Idx = Op.getOperand(2);
+  MVT OpVT = Op.getSimpleValueType();
+  MVT SubVecVT = SubVec.getSimpleValueType();
+    
+  if ((OpVT.is256BitVector() || OpVT.is512BitVector()) &&
+      SubVecVT.is128BitVector() && isa<ConstantSDNode>(Idx)) {
+    unsigned IdxVal = cast<ConstantSDNode>(Idx)->getZExtValue();
+    return Insert128BitVector(Vec, SubVec, IdxVal, DAG, dl);
+  }
 
-    if (Op.getSimpleValueType().is512BitVector() &&
-        SubVec.getSimpleValueType().is256BitVector() &&
-        isa<ConstantSDNode>(Idx)) {
-      unsigned IdxVal = cast<ConstantSDNode>(Idx)->getZExtValue();
-      return Insert256BitVector(Vec, SubVec, IdxVal, DAG, dl);
-    }
+  if (OpVT.is512BitVector() &&
+      SubVecVT.is256BitVector() && isa<ConstantSDNode>(Idx)) {
+    unsigned IdxVal = cast<ConstantSDNode>(Idx)->getZExtValue();
+    return Insert256BitVector(Vec, SubVec, IdxVal, DAG, dl);
   }
+
   return SDValue();
 }
 





More information about the llvm-commits mailing list