[PATCH] Remove support for pnaclcall attribute

Derek Schuff dschuff at google.com
Wed Jan 28 11:10:33 PST 2015


================
Comment at: include/clang-c/Index.h:2857
@@ -2856,3 +2856,3 @@
   CXCallingConv_AAPCS_VFP = 7,
-  CXCallingConv_PnaclCall = 8,
+  CXCallingConv_PnaclCall = 8, /* unused */
   CXCallingConv_IntelOclBicc = 9,
----------------
Removed entirely and left a placeholder comment.

================
Comment at: lib/CodeGen/TargetInfo.cpp:3103
@@ -3102,4 +3102,3 @@
  private:
-  PNaClABIInfo PInfo;  // Used for generating calls with pnaclcall callingconv.
   X86_64ABIInfo NInfo; // Used for everything else.
 };
----------------
jvoung wrote:
> The ' // Used for everything else' comments here and in the ARM version can be removed too.
> 
> Actually, can just the plain X86_64ABIInfo be used where NaClX86_64ABIInfo was, and the latter removed too? Same for ARM.
Yes, Done.
NaCX86_64TargetCodegenInfo can maybe go away too in favor of the vanilla x86_64 one. But there are a couple of differences which I want to test so I'll defer that to another CL.

http://reviews.llvm.org/D7206

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list