[PATCH] Remove gc.roots performCustomLowering
listmail at philipreames.com
Wed Jan 28 10:44:57 PST 2015
Responding to comments. (Those not specifically responded to will be fixed before submission.)
Comment at: docs/GarbageCollection.rst:751
@@ -750,3 @@
-* ``llvm.gcwrite``: Substitute a ``store`` instruction.
> I think these three points can stay in because they're still valid.
They're also covered elsewhere in the same file already.
Comment at: lib/CodeGen/ShadowStackGCLowering.cpp:234
@@ +233,3 @@
+ // (which uses a FunctionPassManager (which segfaults (not asserts) if
+ // provided a ModulePass))).
+ Constant *GV = new GlobalVariable(*F.getParent(), FrameMap->getType(), true,
> I think it's now possible to add ModulePasses to the llc pass pipeline, so changing this pass to be a ModulePass should be possible.
I think this comment is just stale. Given I didn't touch any of this code, I'll leave it as is for now.
More information about the llvm-commits