[PATCH] Make asan_symbolize.py not crash on Windows.

Nico Weber thakis at chromium.org
Wed Jan 28 09:18:04 PST 2015

I'll land the indent changes separately, removed that from this change.

In http://reviews.llvm.org/D7227#114653, @earthdok wrote:

> Wouldn't it be better to do this in the Chromium-specific wrapper (src/tools/valgrind/asan_symbolize.py)?

I moved it into SymbolizationLoop, so that the specific wrapper will do the right thing automatically.

Comment at: lib/asan/scripts/asan_symbolize.py:474
@@ +473,3 @@
+    for line in logfile:
+      print line,
+    sys.exit(0)
glider wrote:
> Nit: spare comma?
No, a traiilng comma in a print line makes print not add a \n. This is intentional because line already ends in a \n.

Comment at: lib/asan/scripts/asan_symbolize.py:443
@@ +442,3 @@
+    # in sandboxed processes.  This script isn't needed there.
+    sys.exit(0)
err actually, I suppose I should copy stdin to stdout too



More information about the llvm-commits mailing list