[llvm] r227044 - [ELFYAML] Support mips64 relocation record format in yaml2obj/obj2yaml

[Kuperstein, Michael M]

Looks good now, thanks for the fix!

-----Original Message-----
From: Simon Atanasyan [mailto:simon at atanasyan.com] 
Sent: Wednesday, January 28, 2015 18:29
To: Kuperstein, Michael M
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm] r227044 - [ELFYAML] Support mips64 relocation record format in yaml2obj/obj2yaml

Hi Michael,

Thanks for pointing out the problem. I hope it has been fixed by r227318.

On Wed, Jan 28, 2015 at 4:12 PM, Kuperstein, Michael M <michael.m.kuperstein at intel.com> wrote:
> This fails on MSVC Debug builds.
> The problem seems to be that the Addend field is uninitialized when it's supposed to be 0, and the result I get is:
>
> Relocations [
>   Section (2) .rela.text {
>     0x14 R_MIPS_GPREL16/R_MIPS_SUB/R_MIPS_HI16 main 0x4
>     0x1C R_MIPS_GPREL16/R_MIPS_SUB/R_MIPS_LO16 main 0x8
>     0x20 R_MIPS_GOT_PAGE/R_MIPS_NONE/R_MIPS_NONE .rodata 0xCDCDCDCDCDCDCDCD
>     0x24 R_MIPS_GOT_OFST/R_MIPS_NONE/R_MIPS_NONE .rodata 0xCDCDCDCDCDCDCDCD
>     0x28 R_MIPS_CALL16/R_MIPS_NONE/R_MIPS_NONE printf 0xCDCDCDCDCDCDCDCD
>     0x30 R_MIPS_GPREL16/R_MIPS_LO16/R_MIPS_NONE printf 0xCDCDCDCDCDCDCDCD
>   }
> ]
>
> Don't know enough about how yaml2obj works to fix it.
> Can you fix or revert?

--
Simon Atanasyan
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.