[PATCH] [CodeGen] Add hooks/combine to form vector extloads, and enable it on X86.

Chandler Carruth chandlerc at gmail.com
Tue Jan 27 19:13:18 PST 2015

My only comments beyond what Hal has already mentioned are real nits:


Can you use DL everywhere? It's odd that in one place you use SDLoc(N0). It may be correct, but if so, it's likely not obvious to the reader why we need to do something different here.

Finally, I'd find the indentation more consistent with clang-format. But now we're waaay down into minor details. This is generally looking much better.



More information about the llvm-commits mailing list