[llvm] r227018 - InstrProf: Add operator!= to coverage counters

Justin Bogner mail at justinbogner.com
Tue Jan 27 17:34:39 PST 2015

David Blaikie <dblaikie at gmail.com> writes:
> On Sat, Jan 24, 2015 at 1:13 PM, Justin Bogner <mail at justinbogner.com> wrote:
>     Author: bogner
>     Date: Sat Jan 24 15:13:23 2015
>     New Revision: 227018
>     URL: http://llvm.org/viewvc/llvm-project?rev=227018&view=rev
>     Log:
>     InstrProf: Add operator!= to coverage counters
>     I'll use this in clang shortly. Also makes the operator definition
>     style more consistent in this class.
> Test cases?

I'm not convinced it's valuable to test an operator!= whose
implementation is literally "return !(LHS == RHS)". If you feel really
strongly I can write some unit tests for this type, but they'll be
pretty pointless.

More information about the llvm-commits mailing list