[PATCH] Remove support for pnaclcall attribute
aaron at aaronballman.com
Tue Jan 27 12:17:59 PST 2015
On Tue, Jan 27, 2015 at 2:50 PM, Derek Schuff <dschuff at google.com> wrote:
> Hi jvoung,
> It was used for interoperability with PNaCl's calling conventions, but
> it's no longer needed.
> Index: include/clang-c/Index.h
> --- include/clang-c/Index.h
> +++ include/clang-c/Index.h
> @@ -2854,7 +2854,7 @@
> CXCallingConv_X86Pascal = 5,
> CXCallingConv_AAPCS = 6,
> CXCallingConv_AAPCS_VFP = 7,
> - CXCallingConv_PnaclCall = 8,
> + CXCallingConv_PnaclCall = 8, /* unused */
Do we have to worry about backwards compatibility for this? If so,
it's not really unused, but reserved.
We may want to rename the identifier to something else as well, since
we don't want people using it. If it truly is unused, we could remove
the enumerator entirely and simply have a comment stating that 8 is
free, but was PnaclCall.
More information about the llvm-commits