[PATCH] tsan: properly instrument unaligned accesses

Dmitry Vyukov dvyukov at google.com
Tue Jan 27 12:17:04 PST 2015


================
Comment at: test/tsan/aligned_vs_unaligned_race.cc:1
@@ -1,2 +1,2 @@
-// RUN: %clangxx_tsan -O1 %s -o %t && %run %t 2>&1 | FileCheck %s
+// RUN: %clangxx_tsan -O1 %s -o %t && %deflake %run %t | FileCheck %s
 // Race between an aligned access and an unaligned access, which
----------------
kcc wrote:
> do you still need deflake here? 
Currently all positive tests use it.
We need a larger cleanup later. But let it be consistent for now.


================
Comment at: test/tsan/aligned_vs_unaligned_race.cc:17
@@ -17,2 +16,3 @@
 void *Thread2(void *x) {
+  sleep(1);
   char *p1 = reinterpret_cast<char *>(&Global[0]);
----------------
kcc wrote:
> you probably want to update the test here (remove sleep)
Done

http://reviews.llvm.org/D7053

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list