[PATCH] Add llvm-pdbdump to tools

Aaron Ballman aaron.ballman at gmail.com
Tue Jan 27 11:26:33 PST 2015


On Tue, Jan 27, 2015 at 1:32 PM, Zachary Turner <zturner at google.com> wrote:
> Aaron, did you specifically want me to wait for your follow up, or were you just wanting me to wait for any LGTM?

A general LGTM would be fine.

LGTM aside from: difference_type should really be std::ptrdiff_t
instead of std::size_t (it needs to be signed instead of unsigned).

~Aaron

>
>
> http://reviews.llvm.org/D7153
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>



More information about the llvm-commits mailing list