[PATCH] Revert 221429 and fix bug in TargetLowering::SimplifyDemandedBits

Quentin Colombet qcolombet at apple.com
Tue Jan 27 10:48:59 PST 2015

Hi Gil,

Thanks for checking.
I will try to give a try later this week.

One question though!

First, some context.
I can see what kind of bug your patch fixes but I am not convinced that we should remove the SHRUNK_BLEND node. This node prevents optimization on VSELECT (either generic or target specific) to take place later on. This is required because the boolean feeding the related node does not match anymore the expected layout of x86 generic boolean and if those optimizations happens, we may generate wrong code.

Please clarify how your patch addresses that.




More information about the llvm-commits mailing list