[PATCH] Fix LLVMSetMetadata for MDNodes that contain a single value

Duncan Exon Smith dexonsmith at apple.com
Tue Jan 27 07:25:07 PST 2015

AFK, sorry for the terseness. 

Looks correct; thanks for working on this. 

- Testcase?
- All the ternary operators are hard to read.  I'd switch to ifs and early returns. 
- Unwrapping Val twice is a little confusing (and, unnecessary). 

-- dpnes

> On Jan 27, 2015, at 1:56 AM, Björn Steinbrink <bsteinbr at gmail.com> wrote:
> I guess I should mention that triggering the assertion is a regression from 3.5.
> http://reviews.llvm.org/D7165
>  http://reviews.llvm.org/settings/panel/emailpreferences/

More information about the llvm-commits mailing list